From: Emil Engler <me@emilengler.com>
Date: Wed, 25 Nov 2020 17:26:56 +0000 (+0100)
Subject: file: avoid duplicated code sequence
X-Git-Tag: curl-7_74_0~34
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=12cb7a1fe0282cc0b1ef4faa6013a2de03028aac;p=thirdparty%2Fcurl.git

file: avoid duplicated code sequence

file_disconnect() is identical with file_do() except the function header
but as the arguments are unused anyway so why not just return file_do()
directly!

Reviewed-by: Daniel Stenberg
Closes #6249
---

diff --git a/lib/file.c b/lib/file.c
index 5f06c4ccab..a65eb7798d 100644
--- a/lib/file.c
+++ b/lib/file.c
@@ -227,18 +227,8 @@ static CURLcode file_done(struct connectdata *conn,
 static CURLcode file_disconnect(struct connectdata *conn,
                                 bool dead_connection)
 {
-  struct FILEPROTO *file = conn->data->req.p.file;
   (void)dead_connection; /* not used */
-
-  if(file) {
-    Curl_safefree(file->freepath);
-    file->path = NULL;
-    if(file->fd != -1)
-      close(file->fd);
-    file->fd = -1;
-  }
-
-  return CURLE_OK;
+  return file_done(conn, 0, 0);
 }
 
 #ifdef DOS_FILESYSTEM