From: Alan Stern <stern@rowland.harvard.edu>
Date: Sun, 13 Jul 2025 15:36:12 +0000 (-0400)
Subject: HID: core: Improve the kerneldoc for hid_report_len()
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=12f33ef6c2aaa410b7ccf039289fe2b04ab2252f;p=thirdparty%2Fkernel%2Flinux.git

HID: core: Improve the kerneldoc for hid_report_len()

The kerneldoc for hid_report_len() needs to be improved.  The
description of the @report argument is ungrammatical, and the
documentation does not explain under what circumstances the report
length will include the byte reserved for the report ID.

Let's fix up the kerneldoc.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://patch.msgid.link/1c8416cb-7347-4a06-b00a-20518069d263@rowland.harvard.edu
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
---

diff --git a/include/linux/hid.h b/include/linux/hid.h
index 7f260e0e20498..2cc4f1e4ea963 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -1216,7 +1216,11 @@ static inline void hid_hw_wait(struct hid_device *hdev)
 /**
  * hid_report_len - calculate the report length
  *
- * @report: the report we want to know the length
+ * @report: the report whose length we want to know
+ *
+ * The length counts the report ID byte, but only if the ID is nonzero
+ * and therefore is included in the report.  Reports whose ID is zero
+ * never include an ID byte.
  */
 static inline u32 hid_report_len(struct hid_report *report)
 {