From: drh Date: Tue, 19 Feb 2019 16:42:54 +0000 (+0000) Subject: Fix an assert() that might not be true if the database file is corrupt. X-Git-Tag: version-3.28.0~176 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=12fe9a0d2512ebbbcc9c492af187ff76404b913e;p=thirdparty%2Fsqlite.git Fix an assert() that might not be true if the database file is corrupt. FossilOrigin-Name: f2d400db4dbfb05e2540178ed3662f97f8c57a95f8129886c7081c35e53adf0d --- diff --git a/manifest b/manifest index c980667aed..d4cd296435 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C New\sassert()\sto\sverify\sthe\sTF_HasprimaryKey\sflag. -D 2019-02-19T13:51:58.095 +C Fix\san\sassert()\sthat\smight\snot\sbe\strue\sif\sthe\sdatabase\sfile\sis\scorrupt. +D 2019-02-19T16:42:54.196 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea F Makefile.in 178d8eb6840771149cee40b322d1b3be30d330198c522c903c1b66fb5a1bfca4 @@ -455,7 +455,7 @@ F src/auth.c 0fac71038875693a937e506bceb492c5f136dd7b1249fbd4ae70b4e8da14f9df F src/backup.c 78d3cecfbe28230a3a9a1793e2ead609f469be43e8f486ca996006be551857ab F src/bitvec.c 17ea48eff8ba979f1f5b04cc484c7bb2be632f33 F src/btmutex.c 8acc2f464ee76324bf13310df5692a262b801808984c1b79defb2503bbafadb6 -F src/btree.c 2105865a621c211cd76d8d21a6831249c31c876d7d1fe7d7ebe27410cd893747 +F src/btree.c 026f48c39b179a5602423904fcaaae87bbd75f659fd672b3756fea43356d9909 F src/btree.h 63b94fb38ce571c15eb6a3661815561b501d23d5948b2d1e951fbd7a2d04e8d3 F src/btreeInt.h 6111c15868b90669f79081039d19e7ea8674013f907710baa3c814dc3f8bfd3f F src/build.c ac41c86b486f480b2bcad7e55c6cc19d7151082f74682ab048c45980d6c9ddac @@ -992,7 +992,7 @@ F test/fuzzdata4.db b502c7d5498261715812dd8b3c2005bad08b3a26e6489414bd13926cd3e4 F test/fuzzdata5.db e35f64af17ec48926481cfaf3b3855e436bd40d1cfe2d59a9474cb4b748a52a5 F test/fuzzdata6.db 92a80e4afc172c24f662a10a612d188fb272de4a9bd19e017927c95f737de6d7 F test/fuzzdata7.db 3fc78e65dfe0be9df9e262075d5a335f18f627da47dfc691d1a7b822f34d4b99 -F test/fuzzdata8.db b7f93d26fb1d29af7c5181eda877f1a20bdbb3d286bc14622e77d08752b6da61 +F test/fuzzdata8.db 04d95f81db43fa4a247531d25573544125d9dd2777ae43594c9eb57e2a8b901c F test/fuzzer1.test 3d4c4b7e547aba5e5511a2991e3e3d07166cfbb8 F test/fuzzer2.test a85ef814ce071293bce1ad8dffa217cbbaad4c14 F test/fuzzerfault.test 8792cd77fd5bce765b05d0c8e01b9edcf8af8536 @@ -1804,7 +1804,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0 -P 55d43adc894a6b1e0f77bf481dad6dd604a0dc0022e72bbf2e3037f97351971e -R 4957484ea90ae4ee926291ee2f0443fe +P 0abace8a7aecca01c8677d07f3ec1bafb289ceffe5bcd60284701a7bf813f415 +R bfae54bdd2f15a7a8fbc764b3228c6f1 U drh -Z 06b0b1933b49b6d18ffce83176015625 +Z aaec93d3bd3865148d42c2428c55baee diff --git a/manifest.uuid b/manifest.uuid index a65f486535..7a8eaf1d80 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -0abace8a7aecca01c8677d07f3ec1bafb289ceffe5bcd60284701a7bf813f415 \ No newline at end of file +f2d400db4dbfb05e2540178ed3662f97f8c57a95f8129886c7081c35e53adf0d \ No newline at end of file diff --git a/src/btree.c b/src/btree.c index 0a8e6a99e4..aa2c84999c 100644 --- a/src/btree.c +++ b/src/btree.c @@ -8261,7 +8261,7 @@ static int balance_deeper(MemPage *pRoot, MemPage **ppChild){ } assert( sqlite3PagerIswriteable(pChild->pDbPage) ); assert( sqlite3PagerIswriteable(pRoot->pDbPage) ); - assert( pChild->nCell==pRoot->nCell ); + assert( pChild->nCell==pRoot->nCell || CORRUPT_DB ); TRACE(("BALANCE: copy root %d into %d\n", pRoot->pgno, pChild->pgno)); diff --git a/test/fuzzdata8.db b/test/fuzzdata8.db index 6ae5d76f4a..ed0d3497b4 100644 Binary files a/test/fuzzdata8.db and b/test/fuzzdata8.db differ