From: Martin Ågren <martin.agren@gmail.com>
Date: Tue, 22 Jan 2019 21:45:47 +0000 (+0100)
Subject: setup: free old value before setting `work_tree`
X-Git-Tag: v2.22.0-rc0~137^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=13019979b811d26f4838d09331c7ddd8223d270d;p=thirdparty%2Fgit.git

setup: free old value before setting `work_tree`

Before assigning to `data->work_tree` in `read_worktree_config()`, free
any value we might already have picked up, so that we do not leak it.

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/setup.c b/setup.c
index 1be5037f12..bb633942bb 100644
--- a/setup.c
+++ b/setup.c
@@ -411,6 +411,7 @@ static int read_worktree_config(const char *var, const char *value, void *vdata)
 	} else if (strcmp(var, "core.worktree") == 0) {
 		if (!value)
 			return config_error_nonbool(var);
+		free(data->work_tree);
 		data->work_tree = xstrdup(value);
 	}
 	return 0;