From: Markus Elfring Date: Mon, 25 Dec 2023 19:03:56 +0000 (+0100) Subject: firmware: tegra: bpmp: Return directly after a failed kzalloc() in get_filename() X-Git-Tag: v6.9-rc1~177^2~7^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1315848f1f8a0100cb6f8a7187bc320c5d98947f;p=thirdparty%2Fkernel%2Flinux.git firmware: tegra: bpmp: Return directly after a failed kzalloc() in get_filename() The kfree() function was called in one case by the get_filename() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software. Thus return directly after a call of the function “kzalloc” failed at the beginning. Signed-off-by: Markus Elfring Signed-off-by: Thierry Reding --- diff --git a/drivers/firmware/tegra/bpmp-debugfs.c b/drivers/firmware/tegra/bpmp-debugfs.c index bbcdd9fed3fb6..4221fed70ad48 100644 --- a/drivers/firmware/tegra/bpmp-debugfs.c +++ b/drivers/firmware/tegra/bpmp-debugfs.c @@ -77,7 +77,7 @@ static const char *get_filename(struct tegra_bpmp *bpmp, root_path_buf = kzalloc(root_path_buf_len, GFP_KERNEL); if (!root_path_buf) - goto out; + return NULL; root_path = dentry_path(bpmp->debugfs_mirror, root_path_buf, root_path_buf_len);