From: Mauro Carvalho Chehab Date: Tue, 7 Aug 2018 09:52:36 +0000 (-0400) Subject: media: imx: shut up a false positive warning X-Git-Tag: v4.19-rc1~137^2~19 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=132f3c7bb98673f713be9511de16b7622803df36;p=thirdparty%2Fkernel%2Flinux.git media: imx: shut up a false positive warning With imx, gcc produces a false positive warning: drivers/staging/media/imx/imx-media-csi.c: In function 'csi_idmac_setup_channel': drivers/staging/media/imx/imx-media-csi.c:457:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (passthrough) { ^ drivers/staging/media/imx/imx-media-csi.c:464:2: note: here default: ^~~~~~~ That's because the regex it uses for fall trough is not good enough. So, rearrange the fall through comment in a way that gcc will recognize. Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 4647206f92ca5..b7ffd231c64b8 100644 --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -460,7 +460,8 @@ static int csi_idmac_setup_channel(struct csi_priv *priv) passthrough_cycles = incc->cycles; break; } - /* fallthrough for non-passthrough RGB565 (CSI-2 bus) */ + /* for non-passthrough RGB565 (CSI-2 bus) */ + /* Falls through */ default: burst_size = (image.pix.width & 0xf) ? 8 : 16; passthrough_bits = 16;