From: Jim Meyering <meyering@redhat.com>
Date: Wed, 24 Sep 2008 13:25:12 +0000 (+0200)
Subject: maint: avoid using find -name Makefile.am; could get false positives
X-Git-Tag: v7.0~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=13a2025998271ad69058987358c92074e627848c;p=thirdparty%2Fcoreutils.git

maint: avoid using find -name Makefile.am; could get false positives

* maint.mk (makefile-check): Instead, search for the offending
@...@ construct only in version-controlled files.
---

diff --git a/maint.mk b/maint.mk
index f3bbf9afad..2987272fb0 100644
--- a/maint.mk
+++ b/maint.mk
@@ -551,7 +551,8 @@ check-AUTHORS:
 # not @...@ in Makefile.am, now that we can rely on automake
 # to emit a definition for each substituted variable.
 makefile-check:
-	@grep -nE '@[A-Z_0-9]+@' `find . -name Makefile.am` \
+	@grep -nE '@[A-Z_0-9]+@'					\
+	    $$($(VC_LIST_EXCEPT) | grep -E '(^|/)Makefile\.am$$')	\
 	  && { echo '$(ME): use $$(...), not @...@' 1>&2; exit 1; } || :
 
 news-date-check: NEWS