From: Zhang Qilong Date: Sat, 28 Nov 2020 13:39:22 +0000 (+0800) Subject: can: kvaser_pciefd: kvaser_pciefd_open(): fix error handling X-Git-Tag: v5.10-rc7~20^2~18^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=13a84cf37a4cf1155a41684236c2314eb40cd65c;p=thirdparty%2Flinux.git can: kvaser_pciefd: kvaser_pciefd_open(): fix error handling If kvaser_pciefd_bus_on() failed, we should call close_candev() to avoid reference leak. Fixes: 26ad340e582d3 ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices") Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20201128133922.3276973-3-zhangqilong3@huawei.com Signed-off-by: Marc Kleine-Budde --- diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c index 72acd1ba162d2..43151dd6cb1c3 100644 --- a/drivers/net/can/kvaser_pciefd.c +++ b/drivers/net/can/kvaser_pciefd.c @@ -692,8 +692,10 @@ static int kvaser_pciefd_open(struct net_device *netdev) return err; err = kvaser_pciefd_bus_on(can); - if (err) + if (err) { + close_candev(netdev); return err; + } return 0; }