From: David Aguilar <davvid@gmail.com>
Date: Wed, 12 Feb 2025 06:04:17 +0000 (-0800)
Subject: xdiff: avoid signed vs. unsigned comparisons in xpatience.c
X-Git-Tag: v2.49.0-rc0~11^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=13b67f15c13d2e45215da8950f31ef27645733c3;p=thirdparty%2Fgit.git

xdiff: avoid signed vs. unsigned comparisons in xpatience.c

The loop iteration variable is non-negative and used in comparisons
against a size_t value. Use size_t to eliminate the mismatch.

Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/xdiff/xpatience.c b/xdiff/xpatience.c
index b0ba421b28..82f663004e 100644
--- a/xdiff/xpatience.c
+++ b/xdiff/xpatience.c
@@ -20,8 +20,6 @@
  *
  */
 
-#define DISABLE_SIGN_COMPARE_WARNINGS
-
 #include "xinclude.h"
 
 /*
@@ -78,7 +76,7 @@ struct hashmap {
 
 static int is_anchor(xpparam_t const *xpp, const char *line)
 {
-	int i;
+	size_t i;
 	for (i = 0; i < xpp->anchors_nr; i++) {
 		if (!strncmp(line, xpp->anchors[i], strlen(xpp->anchors[i])))
 			return 1;