From: Zichen Xie Date: Fri, 15 Nov 2024 06:38:36 +0000 (-0600) Subject: wifi: cfg80211: tests: Fix potential NULL dereference in test_cfg80211_parse_colocate... X-Git-Tag: v6.14-rc1~162^2~181^2~17 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=13c4f7714c6a1ecf748a2f22099447c14fe6ed8c;p=thirdparty%2Fkernel%2Flinux.git wifi: cfg80211: tests: Fix potential NULL dereference in test_cfg80211_parse_colocated_ap() kunit_kzalloc() may return NULL, dereferencing it without NULL check may lead to NULL dereference. Add a NULL check for ies. Fixes: 45d43937a44c ("wifi: cfg80211: add a kunit test for 6 GHz colocated AP parsing") Signed-off-by: Zichen Xie Link: https://patch.msgid.link/20241115063835.5888-1-zichenxie0106@gmail.com Signed-off-by: Johannes Berg --- diff --git a/net/wireless/tests/scan.c b/net/wireless/tests/scan.c index 9f458be716595..79a99cf5e8922 100644 --- a/net/wireless/tests/scan.c +++ b/net/wireless/tests/scan.c @@ -810,6 +810,8 @@ static void test_cfg80211_parse_colocated_ap(struct kunit *test) skb_put_data(input, "123", 3); ies = kunit_kzalloc(test, struct_size(ies, data, input->len), GFP_KERNEL); + KUNIT_ASSERT_NOT_NULL(test, ies); + ies->len = input->len; memcpy(ies->data, input->data, input->len);