From: Andrew Goodbody Date: Tue, 12 Aug 2025 10:13:50 +0000 (+0100) Subject: soc: ti: k3-navss-ringacc: Do not use uninitialised variable X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=13ca68b104ea75d54e86816ba6d86ef5e70a2668;p=thirdparty%2Fu-boot.git soc: ti: k3-navss-ringacc: Do not use uninitialised variable In k3_nav_ringacc_probe_dt there can be no error code returned from dev_read_u32_default so ret is not assigned to and should not be used. Remove the use of ret from the dev_err call as it is unitialised. This issue was found by Smatch. Signed-off-by: Andrew Goodbody --- diff --git a/drivers/soc/ti/k3-navss-ringacc.c b/drivers/soc/ti/k3-navss-ringacc.c index ac29158d489..d37c454143b 100644 --- a/drivers/soc/ti/k3-navss-ringacc.c +++ b/drivers/soc/ti/k3-navss-ringacc.c @@ -932,7 +932,7 @@ static int k3_nav_ringacc_probe_dt(struct k3_nav_ringacc *ringacc) ringacc->num_rings = dev_read_u32_default(dev, "ti,num-rings", 0); if (!ringacc->num_rings) { - dev_err(dev, "ti,num-rings read failure %d\n", ret); + dev_err(dev, "ti,num-rings read failure\n"); return -EINVAL; }