From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Fri, 22 Nov 2019 14:59:55 +0000 (+0200)
Subject: lib: connection: Remove clearing of event fields
X-Git-Tag: 2.3.9~13
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=13cf92a0c34962a94e8aa193d6e13b3582708e94;p=thirdparty%2Fdovecot%2Fcore.git

lib: connection: Remove clearing of event fields

This was done mainly because the fields could have become mixed up when a
client connection event had a parent server connection event. But now that
the IP and port fields are different for client and server connections this
problem mainly doesn't exist.
---

diff --git a/src/lib/connection.c b/src/lib/connection.c
index 82c537d206..b4b049b292 100644
--- a/src/lib/connection.c
+++ b/src/lib/connection.c
@@ -619,8 +619,6 @@ void connection_init_client_ip_from(struct connection_list *list,
 		i_zero(&conn->local_ip);
 
 	connection_init(list, conn, name);
-
-	event_field_clear(conn->event, "socket_path");
 	connection_update_event(conn);
 }
 
@@ -639,12 +637,6 @@ void connection_init_client_unix(struct connection_list *list,
 	conn->unix_socket = TRUE;
 
 	connection_init(list, conn, path);
-
-	event_field_clear(conn->event, "ip");
-	event_field_clear(conn->event, "port");
-	event_field_clear(conn->event, "client_ip");
-	event_field_clear(conn->event, "client_port");
-
 	event_add_str(conn->event, "socket_path", path);
 }