From: Christian König Date: Mon, 18 Oct 2021 19:27:55 +0000 (+0200) Subject: drm/scheduler: fix drm_sched_job_add_implicit_dependencies X-Git-Tag: v5.17-rc1~173^2~20^2~180 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=13e9e30cafea10dff6bc8d63a38a61249e83fd65;p=thirdparty%2Fkernel%2Flinux.git drm/scheduler: fix drm_sched_job_add_implicit_dependencies Trivial fix since we now need to grab a reference to the fence we have added. Previously the dma_resv function where doing that for us. Signed-off-by: Christian König Fixes: 9c2ba265352a ("drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2") Link: https://patchwork.freedesktop.org/patch/msgid/20211019112706.27769-1-christian.koenig@amd.com Reviewed-by: Daniel Vetter Reported-by: Nicolas Frattaroli References: https://lore.kernel.org/dri-devel/2023306.UmlnhvANQh@archbook/ Tested-by: Nicolas Frattaroli --- diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 5bc5f775abe1e..94fe51b3caa20 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -707,6 +707,9 @@ int drm_sched_job_add_implicit_dependencies(struct drm_sched_job *job, ret = drm_sched_job_add_dependency(job, fence); if (ret) return ret; + + /* Make sure to grab an additional ref on the added fence */ + dma_fence_get(fence); } return 0; }