From: Sergey Kitov <sergey.kitov@open-xchange.com>
Date: Thu, 26 Apr 2018 06:48:39 +0000 (+0300)
Subject: plugins/old-stats: Remove restrict_access_set_dumpable calls from process_io_open().
X-Git-Tag: 2.2.36.rc1~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=14015347dfe1393bd0c49263abc308b83f6729ea;p=thirdparty%2Fdovecot%2Fcore.git

plugins/old-stats: Remove restrict_access_set_dumpable calls from process_io_open().

proc_io_fd is opened in preinit(), while process have root access, so
restrict_access_set_dumpable() calls are not needed.
---

diff --git a/src/plugins/stats/mail-stats-fill.c b/src/plugins/stats/mail-stats-fill.c
index 4a24378d75..a2ad387a70 100644
--- a/src/plugins/stats/mail-stats-fill.c
+++ b/src/plugins/stats/mail-stats-fill.c
@@ -2,7 +2,6 @@
 
 #include "lib.h"
 #include "time-util.h"
-#include "restrict-access.h"
 #include "stats-plugin.h"
 #include "mail-stats.h"
 
@@ -47,9 +46,6 @@ static int process_io_open(void)
 	if (proc_io_disabled)
 		return -1;
 
-	bool dumpable = restrict_access_get_dumpable();
-	if (!dumpable)
-		restrict_access_set_dumpable(TRUE);
 	proc_io_fd = open(PROC_IO_PATH, O_RDONLY);
 	if (proc_io_fd == -1 && errno == EACCES) {
 		/* kludge: if we're running with permissions temporarily
@@ -65,8 +61,6 @@ static int process_io_open(void)
 		}
 		errno = EACCES;
 	}
-	if (!dumpable)
-		restrict_access_set_dumpable(FALSE);
 	if (proc_io_fd == -1) {
 		if (errno != ENOENT)
 			i_error("open(%s) failed: %m", PROC_IO_PATH);