From: Vladimir Oltean Date: Fri, 4 Oct 2024 11:00:12 +0000 (+0300) Subject: lib: packing: catch kunit_kzalloc() failure in the pack() test X-Git-Tag: v6.13-rc1~135^2~405 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1405981bbba0796530311d07a67bf58228cc0fcc;p=thirdparty%2Fkernel%2Flinux.git lib: packing: catch kunit_kzalloc() failure in the pack() test kunit_kzalloc() may fail. Other call sites verify that this is the case, either using a direct comparison with the NULL pointer, or the KUNIT_ASSERT_NOT_NULL() or KUNIT_ASSERT_NOT_ERR_OR_NULL(). Pick KUNIT_ASSERT_NOT_NULL() as the error handling method that made most sense to me. It's an unlikely thing to happen, but at least we call __kunit_abort() instead of dereferencing this NULL pointer. Fixes: e9502ea6db8a ("lib: packing: add KUnit tests adapted from selftests") Signed-off-by: Vladimir Oltean Link: https://patch.msgid.link/20241004110012.1323427-1-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski --- diff --git a/lib/packing_test.c b/lib/packing_test.c index 015ad1180d23d..b38ea43c03fd8 100644 --- a/lib/packing_test.c +++ b/lib/packing_test.c @@ -375,6 +375,7 @@ static void packing_test_pack(struct kunit *test) int err; pbuf = kunit_kzalloc(test, params->pbuf_size, GFP_KERNEL); + KUNIT_ASSERT_NOT_NULL(test, pbuf); err = pack(pbuf, params->uval, params->start_bit, params->end_bit, params->pbuf_size, params->quirks);