From: Jeremy Allison <jra@samba.org>
Date: Tue, 21 Jul 2020 00:28:41 +0000 (-0700)
Subject: s3: libsmb: Cleanup - split allocation and NULL check in internal_resolve_name().
X-Git-Tag: talloc-2.3.2~960
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=14433e2afad805a0481ca72c7108232d030919f2;p=thirdparty%2Fsamba.git

s3: libsmb: Cleanup - split allocation and NULL check in internal_resolve_name().

No logic change.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
---

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 314484e48d5..e20a96239c9 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -2603,8 +2603,8 @@ NTSTATUS internal_resolve_name(const char *name,
 			name, name_type, sitename ? sitename : "(null)"));
 
 	if (is_ipaddress(name)) {
-		if ((*return_iplist = SMB_MALLOC_P(struct ip_service)) ==
-				NULL) {
+		*return_iplist = SMB_MALLOC_P(struct ip_service);
+		if (*return_iplist == NULL) {
 			DEBUG(0,("internal_resolve_name: malloc fail !\n"));
 			return NT_STATUS_NO_MEMORY;
 		}