From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Fri, 4 Mar 2022 15:51:20 +0000 (+0100)
Subject: CLEANUP: quic: complete ABORT_NOW with a TODO comment
X-Git-Tag: v2.6-dev3~66
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1455113e93463146a79332de8c74edba1c368dcf;p=thirdparty%2Fhaproxy.git

CLEANUP: quic: complete ABORT_NOW with a TODO comment

Add a TODO comment to not forget to properly implement error returned by
qcs_push_frame.
---

diff --git a/src/mux_quic.c b/src/mux_quic.c
index c6f12cb85f..3ae919364c 100644
--- a/src/mux_quic.c
+++ b/src/mux_quic.c
@@ -418,8 +418,7 @@ static int qc_send(struct qcc *qcc)
 		if (b_data(buf)) {
 			char fin = qcs->flags & QC_SF_FIN_STREAM;
 			ret = qcs_push_frame(qcs, buf, fin, qcs->tx.offset);
-			if (ret < 0)
-				ABORT_NOW();
+			BUG_ON(ret < 0); /* TODO handle this properly */
 
 			if (ret > 0) {
 				qcs_notify_send(qcs);