From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Fri, 17 Mar 2023 12:23:46 +0000 (+0100)
Subject: avoid char signedness trap
X-Git-Tag: auth-4.8.0-alpha1~1^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=148da7e6db13c1f56c068a246ff7ea390d98d6da;p=thirdparty%2Fpdns.git

avoid char signedness trap
---

diff --git a/ext/lmdb-safe/lmdb-safe.cc b/ext/lmdb-safe/lmdb-safe.cc
index 083d0661b3..4a146feba4 100644
--- a/ext/lmdb-safe/lmdb-safe.cc
+++ b/ext/lmdb-safe/lmdb-safe.cc
@@ -42,7 +42,8 @@ namespace LMDBLS {
 
     size_t headersize = LS_MIN_HEADER_SIZE;
 
-    uint16_t numextra = (val[LS_NUMEXTRA_OFFSET] << 8) + val[LS_NUMEXTRA_OFFSET+1];
+    unsigned char* tmp = (unsigned char*)val.data();
+    uint16_t numextra = (tmp[LS_NUMEXTRA_OFFSET] << 8) + tmp[LS_NUMEXTRA_OFFSET+1];
 
     headersize += numextra * LS_BLOCK_SIZE;