From: Duncan Grisby <duncan-github@grisby.org>
Date: Tue, 23 Aug 2022 06:28:43 +0000 (+0100)
Subject: gh-96159: Fix significant performance degradation in logging.TimedRotat… (GH-96182)
X-Git-Tag: v3.12.0a1~589
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1499d73b3e02878850c007fa7298bb62f6c5a9a1;p=thirdparty%2FPython%2Fcpython.git

gh-96159: Fix significant performance degradation in logging.TimedRotat… (GH-96182)
---

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index 1c8226c18163..3f97862cc37a 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -348,11 +348,15 @@ class TimedRotatingFileHandler(BaseRotatingHandler):
         record is not used, as we are just comparing times, but it is needed so
         the method signatures are the same
         """
-        # See bpo-45401: Never rollover anything other than regular files
-        if os.path.exists(self.baseFilename) and not os.path.isfile(self.baseFilename):
-            return False
         t = int(time.time())
         if t >= self.rolloverAt:
+            # See #89564: Never rollover anything other than regular files
+            if os.path.exists(self.baseFilename) and not os.path.isfile(self.baseFilename):
+                # The file is not a regular file, so do not rollover, but do
+                # set the next rollover time to avoid repeated checks.
+                self.rolloverAt = self.computeRollover(t)
+                return False
+
             return True
         return False
 
diff --git a/Misc/NEWS.d/next/Library/2022-08-22-18-42-17.gh-issue-96159.3bFU39.rst b/Misc/NEWS.d/next/Library/2022-08-22-18-42-17.gh-issue-96159.3bFU39.rst
new file mode 100644
index 000000000000..f64469e563f3
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-08-22-18-42-17.gh-issue-96159.3bFU39.rst
@@ -0,0 +1 @@
+Fix a performance regression in logging TimedRotatingFileHandler. Only check for special files when the rollover time has passed.