From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 8 Apr 2019 08:43:46 +0000 (+0200)
Subject: MINOR: mux-h1: Don't release the conn_stream anymore when h1s is destroyed
X-Git-Tag: v2.0-dev3~301
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=14c91cfdf8f2fea0094afa94b00bee9cc875f769;p=thirdparty%2Fhaproxy.git

MINOR: mux-h1: Don't release the conn_stream anymore when h1s is destroyed

An H1 stream is destroyed when the conn_stream is detached or when the H1
connection is destroyed. In the first case, the CS is released by the caller. In
the second one, because the connection is closed, no CS is attached anymore. In
both, there is no reason to release the conn_stream in h1s_destroy().
---

diff --git a/src/mux_h1.c b/src/mux_h1.c
index 08dd0ba8f1..30bb5f7aee 100644
--- a/src/mux_h1.c
+++ b/src/mux_h1.c
@@ -341,8 +341,6 @@ static void h1s_destroy(struct h1s *h1s)
 		h1c->flags |= H1C_F_WAIT_NEXT_REQ;
 		if (h1s->flags & (H1S_F_REQ_ERROR|H1S_F_RES_ERROR))
 			h1c->flags |= H1C_F_CS_ERROR;
-
-		cs_free(h1s->cs);
 		pool_free(pool_head_h1s, h1s);
 	}
 }