From: Michael Tremer <michael.tremer@ipfire.org>
Date: Wed, 6 Jan 2021 11:45:20 +0000 (+0000)
Subject: misc-progs: smartctrl: Sanitise device name
X-Git-Tag: v2.25-core155~222
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=14dc1c68f75b2ea70c0acfc55c1c168cc1ba8dff;p=ipfire-2.x.git

misc-progs: smartctrl: Sanitise device name

Fixes: #12562
Reported-by: Albert Schwarzkopf <ipfire@quitesimple.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/misc-progs/smartctrl.c b/src/misc-progs/smartctrl.c
index c6451acba3..22f0e0a10a 100644
--- a/src/misc-progs/smartctrl.c
+++ b/src/misc-progs/smartctrl.c
@@ -22,6 +22,11 @@ int main(int argc, char *argv[]) {
 		exit(1);
 	}
 
+	if (!is_valid_argument_alnum(argv[1])) {
+		fprintf(stderr, "Invalid device name '%s'\n", argv[1]);
+		exit(2);
+	}
+
 	char command[STRING_SIZE];
 	snprintf(command, STRING_SIZE, "/var/run/hddshutdown-%s", argv[1]);