From: Dan Carpenter Date: Tue, 18 Nov 2025 10:48:56 +0000 (+0300) Subject: rtc: atcrtc100: Fix signedness bug in probe() X-Git-Tag: v6.19-rc1~15^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=159a740c768e4e8fe3c63d20055bf54de29c0c02;p=thirdparty%2Flinux.git rtc: atcrtc100: Fix signedness bug in probe() The "atcrtc_dev->alarm_irq" variable is an unsigned int but it needs to be signed for the error handling to work. Use the "ret" variable instead. Fixes: 7adca706fe16 ("rtc: atcrtc100: Add ATCRTC100 RTC driver") Signed-off-by: Dan Carpenter Link: https://patch.msgid.link/aRxPGBEX8hbY6sjV@stanley.mountain Signed-off-by: Alexandre Belloni --- diff --git a/drivers/rtc/rtc-atcrtc100.c b/drivers/rtc/rtc-atcrtc100.c index 51933ae1a2fa..9808fc2c5a49 100644 --- a/drivers/rtc/rtc-atcrtc100.c +++ b/drivers/rtc/rtc-atcrtc100.c @@ -296,10 +296,12 @@ static int atcrtc_probe(struct platform_device *pdev) "Failed to initialize RTC: unsupported hardware ID 0x%x\n", rtc_id); - atcrtc_dev->alarm_irq = platform_get_irq(pdev, 1); - if (atcrtc_dev->alarm_irq < 0) - return dev_err_probe(&pdev->dev, atcrtc_dev->alarm_irq, + ret = platform_get_irq(pdev, 1); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "Failed to get IRQ for alarm\n"); + atcrtc_dev->alarm_irq = ret; + ret = devm_request_irq(&pdev->dev, atcrtc_dev->alarm_irq, atcrtc_alarm_isr,