From: Greg Kroah-Hartman Date: Fri, 9 Sep 2016 13:47:06 +0000 (+0200) Subject: 3.14-stable patches X-Git-Tag: v3.14.79~17 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=15bf38f8f8c78b115069608c0ac22e8269a557bc;p=thirdparty%2Fkernel%2Fstable-queue.git 3.14-stable patches added patches: net-use-ns_capable_noaudit-when-determining-net-sysctl-permissions.patch --- diff --git a/queue-3.14/net-use-ns_capable_noaudit-when-determining-net-sysctl-permissions.patch b/queue-3.14/net-use-ns_capable_noaudit-when-determining-net-sysctl-permissions.patch new file mode 100644 index 00000000000..40ae2277517 --- /dev/null +++ b/queue-3.14/net-use-ns_capable_noaudit-when-determining-net-sysctl-permissions.patch @@ -0,0 +1,42 @@ +From d6e0d306449bcb5fa3c80e7a3edf11d45abf9ae9 Mon Sep 17 00:00:00 2001 +From: Tyler Hicks +Date: Thu, 2 Jun 2016 23:43:22 -0500 +Subject: net: Use ns_capable_noaudit() when determining net sysctl permissions + +From: Tyler Hicks + +commit d6e0d306449bcb5fa3c80e7a3edf11d45abf9ae9 upstream. + +The capability check should not be audited since it is only being used +to determine the inode permissions. A failed check does not indicate a +violation of security policy but, when an LSM is enabled, a denial audit +message was being generated. + +The denial audit message caused confusion for some application authors +because root-running Go applications always triggered the denial. To +prevent this confusion, the capability check in net_ctl_permissions() is +switched to the noaudit variant. + +BugLink: https://launchpad.net/bugs/1465724 + +Signed-off-by: Tyler Hicks +Acked-by: Serge E. Hallyn +Signed-off-by: James Morris +Signed-off-by: Sasha Levin +Signed-off-by: Greg Kroah-Hartman + +--- + net/sysctl_net.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/net/sysctl_net.c ++++ b/net/sysctl_net.c +@@ -46,7 +46,7 @@ static int net_ctl_permissions(struct ct + kgid_t root_gid = make_kgid(net->user_ns, 0); + + /* Allow network administrator to have same access as root. */ +- if (ns_capable(net->user_ns, CAP_NET_ADMIN) || ++ if (ns_capable_noaudit(net->user_ns, CAP_NET_ADMIN) || + uid_eq(root_uid, current_euid())) { + int mode = (table->mode >> 6) & 7; + return (mode << 6) | (mode << 3) | mode; diff --git a/queue-3.14/series b/queue-3.14/series index b2a72bcc0e8..251103ee0e9 100644 --- a/queue-3.14/series +++ b/queue-3.14/series @@ -3,3 +3,4 @@ be2iscsi-fix-bogus-warn_on-length-check.patch hid-hid-input-add-parentheses-to-quell-gcc-warning.patch alsa-oxygen-fix-logical-not-parentheses-warning.patch stb6100-fix-buffer-length-check-in-stb6100_write_reg_range.patch +net-use-ns_capable_noaudit-when-determining-net-sysctl-permissions.patch