From: Lorenzo Bianconi Date: Sat, 21 Sep 2019 08:44:01 +0000 (+0200) Subject: mt7601u: fix bbp version check in mt7601u_wait_bbp_ready X-Git-Tag: v5.5-rc1~174^2~213^2~104 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=15e14f76f85f4f0eab3b8146e1cd3c58ce272823;p=thirdparty%2Fkernel%2Flinux.git mt7601u: fix bbp version check in mt7601u_wait_bbp_ready Fix bbp ready check in mt7601u_wait_bbp_ready. The issue is reported by coverity with the following error: Logical vs. bitwise operator The expression's value does not depend on the operands; inadvertent use of the wrong operator is a likely logic error. Addresses-Coverity-ID: 1309441 ("Logical vs. bitwise operator") Fixes: c869f77d6abb ("add mt7601u driver") Acked-by: Jakub Kicinski Signed-off-by: Lorenzo Bianconi Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c index 06f5702ab4bd0..d863ab4a66c96 100644 --- a/drivers/net/wireless/mediatek/mt7601u/phy.c +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) do { val = mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); - if (val && ~val) + if (val && val != 0xff) break; } while (--i);