From: Michael Paquier <michael@paquier.xyz>
Date: Thu, 19 Jan 2023 04:13:32 +0000 (+0900)
Subject: Add missing assign hook for GUC checkpoint_completion_target
X-Git-Tag: REL_12_14~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=162a48287f1d6fce0c6a927e08bf94ebe31a46e1;p=thirdparty%2Fpostgresql.git

Add missing assign hook for GUC checkpoint_completion_target

This is wrong since 88e9823, that has switched the WAL sizing
configuration from checkpoint_segments to min_wal_size and
max_wal_size.  This missed the recalculation of the internal value of
the internal "CheckPointSegments", that works as a mapping of the old
GUC checkpoint_segments, on reload, for example, and it controls the
timing of checkpoints depending on the volume of WAL generated.

Most users tend to leave checkpoint_completion_target at 0.9 to smooth
the I/O workload, which is why I guess this has gone unnoticed for so
long, still it can be useful to tweak and reload the value dynamically
in some cases to control the timing of checkpoints.

Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.com
Backpatch-through: 11
---

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 2ec82406dd3..bd03965a759 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -3429,7 +3429,7 @@ static struct config_real ConfigureNamesReal[] =
 		},
 		&CheckPointCompletionTarget,
 		0.5, 0.0, 1.0,
-		NULL, NULL, NULL
+		NULL, assign_checkpoint_completion_target, NULL
 	},
 
 	{