From: Gert Doering Date: Wed, 17 Sep 2025 12:07:15 +0000 (+0200) Subject: dev-tools/gerrit-send-mail.py: include Gerrit URL into the commit message X-Git-Tag: v2.7_beta2~24 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=168792766dedc2dab41347fa394fc244c73247e8;p=thirdparty%2Fopenvpn.git dev-tools/gerrit-send-mail.py: include Gerrit URL into the commit message We used to reference to one of the mailing list archives as the formal reference for the patch and the review discussions. With the problematic reliability of the archives, I've started to manually add the URLs in the OpenVPN Gerrit to the commits because they give a better reference and (usually) all the feedback is there in a useful format. So, enhance this dev-tool script to do this automatically. Change-Id: Idb137ecbade4b0584a4d74aee34978062e247bc5 Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1196 Message-Id: <20250917120720.30738-1-gert@greenie.muc.de> URL: https://sourceforge.net/p/openvpn/mailman/message/59234672/ Signed-off-by: Gert Doering --- diff --git a/dev-tools/gerrit-send-mail.py b/dev-tools/gerrit-send-mail.py index 0b49ae9d1..450e920e4 100755 --- a/dev-tools/gerrit-send-mail.py +++ b/dev-tools/gerrit-send-mail.py @@ -99,6 +99,7 @@ def apply_patch_mods(patch_text, details, args): assert comment_start > signed_off_end acked_by_text = "" acked_by_names = "" + gerrit_url = f"{args.url}/c/{details['project']}/+/{args.changeid}" for ack in details["acked_by"]: acked_by_text += f"Acked-by: {ack}\n" acked_by_names += f"{ack}\n" @@ -106,12 +107,13 @@ def apply_patch_mods(patch_text, details, args): patch_text[:signed_off_end] + signed_off_text + acked_by_text + + f"Gerrit URL: {gerrit_url}\n" + patch_text[signed_off_end:comment_start] + f""" This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to {details["target"]}. -Gerrit URL: {args.url}/c/{details["project"]}/+/{args.changeid} +Gerrit URL: {gerrit_url} This mail reflects revision {details["revision"]} of this Change. {signed_off_comment} Acked-by according to Gerrit (reflected above):