From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Wed, 18 May 2016 18:41:49 +0000 (+0300)
Subject: lib-imap-storage: Don't sort uninitialized array on invalid header list.
X-Git-Tag: 2.2.25.rc1~202
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=169c8862c63aaffad634961241ea3d0df7825f39;p=thirdparty%2Fdovecot%2Fcore.git

lib-imap-storage: Don't sort uninitialized array on invalid header list.
---

diff --git a/src/lib-imap-storage/imap-msgpart.c b/src/lib-imap-storage/imap-msgpart.c
index 3c719eeaba..7eeabb0faf 100644
--- a/src/lib-imap-storage/imap-msgpart.c
+++ b/src/lib-imap-storage/imap-msgpart.c
@@ -166,13 +166,12 @@ imap_msgpart_get_header_fields(pool_t pool, const char *header_list,
 			value = p_strdup(pool, t_str_ucase(value));
 			array_append(fields, &value, 1);
 		}
+		/* istream-header-filter requires headers to be sorted */
+		array_sort(fields, i_strcasecmp_p);
 	} else {
 		result = -1;
 	}
 
-	/* istream-header-filter requires headers to be sorted */
-	array_sort(fields, i_strcasecmp_p);
-
 	imap_parser_unref(&parser);
 	i_stream_unref(&input);
 	return result;