From: Troy Mitchell Date: Tue, 18 Nov 2025 06:08:06 +0000 (+0800) Subject: rtc: spacemit: MFD_SPACEMIT_P1 as dependencies X-Git-Tag: v6.19-rc1~15^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=16bd954c93360145bc77cc601e350913fc28182d;p=thirdparty%2Fkernel%2Flinux.git rtc: spacemit: MFD_SPACEMIT_P1 as dependencies RTC_DRV_SPACEMIT_P1 is a subdevice of P1 and should depend on MFD_SPACEMIT_P1 rather than selecting it directly. Using 'select' does not always respect the parent's dependencies, so 'depends on' is the safer and more correct choice. Additionally, the default value depends on MFD_SPACEMIT_P1 rather than ARCH_SPACEMIT. Signed-off-by: Troy Mitchell Acked-by: Alex Elder Link: https://patch.msgid.link/20251118-p1-kconfig-fix-v3-2-8839c5ac5db3@linux.spacemit.com Signed-off-by: Alexandre Belloni --- diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 9906cddd5a8b..50dc779f7f98 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -409,8 +409,8 @@ config RTC_DRV_MAX77686 config RTC_DRV_SPACEMIT_P1 tristate "SpacemiT P1 RTC" depends on ARCH_SPACEMIT || COMPILE_TEST - select MFD_SPACEMIT_P1 - default ARCH_SPACEMIT + depends on MFD_SPACEMIT_P1 + default MFD_SPACEMIT_P1 help Enable support for the RTC function in the SpacemiT P1 PMIC. This driver can also be built as a module, which will be called