From: Phil Blundell Date: Sun, 11 Mar 2001 13:12:59 +0000 (+0000) Subject: 2001-03-11 Philip Blundell X-Git-Tag: binutils-2_11~35 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=16d8c29c89d36e4026a912a718d3737c3fc0b426;p=thirdparty%2Fbinutils-gdb.git 2001-03-11 Philip Blundell * elf32-arm.h (elf32_arm_finish_dynamic_symbol): Don't make PLT entries that could serve as a definition for a weak symbol. --- diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 3661bf3ae18..3173d201cfe 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2001-03-11 Philip Blundell + + * elf32-arm.h (elf32_arm_finish_dynamic_symbol): Don't make PLT + entries that could serve as a definition for a weak symbol. + 2001-03-07 Andreas Jaeger * elf64-x86-64.c (elf64_x86_64_relocate_section): Fix handling of diff --git a/bfd/elf32-arm.h b/bfd/elf32-arm.h index abda34ddbe9..0f2ac8a9d16 100644 --- a/bfd/elf32-arm.h +++ b/bfd/elf32-arm.h @@ -3167,6 +3167,13 @@ elf32_arm_finish_dynamic_symbol (output_bfd, info, h, sym) /* Mark the symbol as undefined, rather than as defined in the .plt section. Leave the value alone. */ sym->st_shndx = SHN_UNDEF; + /* If the symbol is weak, we do need to clear the value. + Otherwise, the PLT entry would provide a definition for + the symbol even if the symbol wasn't defined anywhere, + and so the symbol would never be NULL. */ + if ((h->elf_link_hash_flags & ELF_LINK_HASH_REF_REGULAR_NONWEAK) + == 0) + sym->st_value = 0; } }