From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Mon, 14 Feb 2022 16:32:50 +0000 (+0100)
Subject: MINOR: quic: Code never reached in qc_ssl_sess_init()
X-Git-Tag: v2.6-dev2~138
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=16de9f7dbf44f1e2e2b9992f791f141358a07e14;p=thirdparty%2Fhaproxy.git

MINOR: quic: Code never reached in qc_ssl_sess_init()

There was a remaining useless statement in this code block.
This fixes CID 1469648 for GH #1546
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index f4a825b792..ffd9941854 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -4107,8 +4107,6 @@ static int qc_ssl_sess_init(struct quic_conn *qc, SSL_CTX *ssl_ctx, SSL **ssl,
 	if (!SSL_set_quic_method(*ssl, &ha_quic_method) ||
 	    !SSL_set_ex_data(*ssl, ssl_qc_app_data_index, qc) ||
 	    !SSL_set_quic_transport_params(*ssl, qc->enc_params, qc->enc_params_len)) {
-			goto err;
-
 		SSL_free(*ssl);
 		*ssl = NULL;
 		if (!retry--)