From: Jinjie Ruan Date: Thu, 7 Nov 2024 11:38:41 +0000 (+0800) Subject: cpufreq: mediatek-hw: Fix wrong return value in mtk_cpufreq_get_cpu_power() X-Git-Tag: v6.13-rc1~107^2~1^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=172bf5ed04cb6c9e66d58de003938ed5c8756570;p=thirdparty%2Fkernel%2Flinux.git cpufreq: mediatek-hw: Fix wrong return value in mtk_cpufreq_get_cpu_power() mtk_cpufreq_get_cpu_power() return 0 if the policy is NULL. Then in em_create_perf_table(), the later zero check for power is not invalid as power is uninitialized. As Lukasz suggested, it must return -EINVAL when the 'policy' is not found. So return -EINVAL to fix it. Cc: stable@vger.kernel.org Fixes: 4855e26bcf4d ("cpufreq: mediatek-hw: Add support for CPUFREQ HW") Reviewed-by: Lukasz Luba Suggested-by: Lukasz Luba Signed-off-by: Jinjie Ruan Signed-off-by: Viresh Kumar --- diff --git a/drivers/cpufreq/mediatek-cpufreq-hw.c b/drivers/cpufreq/mediatek-cpufreq-hw.c index 8925e096d5b9a..aeb5e63045421 100644 --- a/drivers/cpufreq/mediatek-cpufreq-hw.c +++ b/drivers/cpufreq/mediatek-cpufreq-hw.c @@ -62,7 +62,7 @@ mtk_cpufreq_get_cpu_power(struct device *cpu_dev, unsigned long *uW, policy = cpufreq_cpu_get_raw(cpu_dev->id); if (!policy) - return 0; + return -EINVAL; data = policy->driver_data;