From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Fri, 28 Feb 2014 11:22:25 +0000 (+0200)
Subject: Remove bogus while-loop.
X-Git-Tag: REL9_3_4~28
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=17450cb6809f534283545f629082efcd3ea904ed;p=thirdparty%2Fpostgresql.git

Remove bogus while-loop.

Commit abf5c5c9a4f142b3343614746bb9e99a794f8e7b added a bogus while-
statement after the for(;;)-loop. It went unnoticed in testing, because
it was dead code.

Report by KONDO Mitsumasa. Backpatch to 9.3. The commit that introduced
this was also applied to 9.2, but not the bogus while-loop part, because
the code in 9.2 looks quite different.
---

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index d57bf50e0b4..7399fd45c81 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -9906,9 +9906,9 @@ WaitForWALToBecomeAvailable(XLogRecPtr RecPtr, bool randAccess,
 		 * process.
 		 */
 		HandleStartupProcInterrupts();
-	} while (StandbyMode);
+	}
 
-	return false;
+	return false; 	/* not reached */
 }
 
 /*