From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Wed, 7 Jun 2017 09:37:09 +0000 (+0300)
Subject: lib-mail: message_address_write() - Always write <user@domain> as output
X-Git-Tag: 2.2.31.rc1~93
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=175de9ec7ccbf1d16f3a2fc0da92ced12b8931eb;p=thirdparty%2Fdovecot%2Fcore.git

lib-mail: message_address_write() - Always write <user@domain> as output

This is the standard format nowadays, so don't convert <user@domain> into
plain user@domain.
---

diff --git a/src/lib-mail/message-address.c b/src/lib-mail/message-address.c
index 9c9ab71b04..ec8e4e009e 100644
--- a/src/lib-mail/message-address.c
+++ b/src/lib-mail/message-address.c
@@ -444,18 +444,8 @@ void message_address_write(string_t *str, const struct message_address *addr)
 			}
 
 			in_group = !in_group;
-		} else if ((addr->name == NULL || *addr->name == '\0') &&
-			   addr->route == NULL) {
-			/* no name and no route. use only mailbox@domain */
-			i_assert(addr->mailbox != NULL);
-
-			str_append_maybe_escape(str, addr->mailbox, FALSE);
-			if (addr->domain[0] != '\0') {
-				str_append_c(str, '@');
-				str_append(str, addr->domain);
-			}
 		} else {
-			/* name and/or route. use full <mailbox@domain> Name */
+			/* "Display Name" <mailbox@domain> */
 			i_assert(addr->mailbox != NULL);
 
 			if (addr->name != NULL) {
diff --git a/src/lib-mail/test-message-address.c b/src/lib-mail/test-message-address.c
index c8d3edaa78..23d77d5f41 100644
--- a/src/lib-mail/test-message-address.c
+++ b/src/lib-mail/test-message-address.c
@@ -22,9 +22,9 @@ static void test_message_address(void)
 		const char *wanted_output;
 		struct message_address addr;
 	} tests[] = {
-		{ "user@domain", NULL,
+		{ "user@domain", "<user@domain>",
 		  { NULL, NULL, NULL, "user", "domain", FALSE } },
-		{ "<user@domain>", "user@domain",
+		{ "<user@domain>", NULL,
 		  { NULL, NULL, NULL, "user", "domain", FALSE } },
 		{ "foo bar <user@domain>", "\"foo bar\" <user@domain>",
 		  { NULL, "foo bar", NULL, "user", "domain", FALSE } },
@@ -44,7 +44,7 @@ static void test_message_address(void)
 		  { NULL, "hello", NULL, "user", "", TRUE } },
 		{ "hello <user>", "hello <user>",
 		  { NULL, "hello", NULL, "user", "", TRUE } },
-		{ "@domain", NULL,
+		{ "@domain", "<@domain>",
 		  { NULL, NULL, NULL, "", "domain", TRUE } },
 	};
 	static struct message_address group_prefix = {