From: Timo Sirainen <tss@iki.fi>
Date: Wed, 17 Nov 2010 17:52:52 +0000 (+0000)
Subject: lib-master: If auth master login fails, make sure error message is logged.
X-Git-Tag: 2.0.8~75
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=178839556a2bf4608e9a186efb78d9b054e6d153;p=thirdparty%2Fdovecot%2Fcore.git

lib-master: If auth master login fails, make sure error message is logged.
---

diff --git a/src/lib-master/master-login-auth.c b/src/lib-master/master-login-auth.c
index 3d366fbc14..373a17d818 100644
--- a/src/lib-master/master-login-auth.c
+++ b/src/lib-master/master-login-auth.c
@@ -79,6 +79,8 @@ void master_login_auth_disconnect(struct master_login_auth *auth)
 {
 	struct master_login_auth_request *request;
 
+	if (auth->request_head != NULL)
+		i_error("Disconnected from auth server, aborting requests");
 	while (auth->request_head != NULL) {
 		request = auth->request_head;
 		DLLIST2_REMOVE(&auth->request_head,
@@ -272,8 +274,10 @@ master_login_auth_input_fail(struct master_login_auth *auth,
 
 	request = master_login_auth_lookup_request(auth, id);
 	if (request != NULL) {
-		if (error != NULL)
+		if (error == NULL)
 			i_error("Internal auth failure");
+		else
+			i_error("Internal auth failure: %s", error);
 		request->callback(NULL, error != NULL ? error :
 				  MASTER_AUTH_ERRMSG_INTERNAL_FAILURE,
 				  request->context);