From: Johannes Schindelin Date: Tue, 7 Sep 2021 21:05:12 +0000 (+0000) Subject: sequencer: restrict scope of a formerly public function X-Git-Tag: v2.34.0-rc0~53^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=17919c3585ba9df9c65ea4a5f7300543dfba5f9f;p=thirdparty%2Fgit.git sequencer: restrict scope of a formerly public function The function to add the `exec` commands to the todo list only needed to be public API because it was not only used internally by the sequencer, but also by `git rebase --preserve-merges`. Now that that mode has been removed, we no longer need that function to be scoped publicly. Helped-by: Alban Gruin Signed-off-by: Johannes Schindelin Reviewed-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano --- diff --git a/sequencer.c b/sequencer.c index 7f07cd00f3..3cdb20b074 100644 --- a/sequencer.c +++ b/sequencer.c @@ -5387,8 +5387,8 @@ int sequencer_make_script(struct repository *r, struct strbuf *out, int argc, * Add commands after pick and (series of) squash/fixup commands * in the todo list. */ -void todo_list_add_exec_commands(struct todo_list *todo_list, - struct string_list *commands) +static void todo_list_add_exec_commands(struct todo_list *todo_list, + struct string_list *commands) { struct strbuf *buf = &todo_list->buf; size_t base_offset = buf->len; diff --git a/sequencer.h b/sequencer.h index d57d8ea23d..60a156ea90 100644 --- a/sequencer.h +++ b/sequencer.h @@ -160,8 +160,6 @@ int sequencer_remove_state(struct replay_opts *opts); int sequencer_make_script(struct repository *r, struct strbuf *out, int argc, const char **argv, unsigned flags); -void todo_list_add_exec_commands(struct todo_list *todo_list, - struct string_list *commands); int complete_action(struct repository *r, struct replay_opts *opts, unsigned flags, const char *shortrevisions, const char *onto_name, struct commit *onto, const struct object_id *orig_head,