From: Gustavo A. R. Silva <gustavo@embeddedor.com>
Date: Fri, 20 Jul 2018 15:01:58 +0000 (-0500)
Subject: PCI: mediatek: Fix unchecked return value
X-Git-Tag: v4.20-rc1~128^2~2^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=17a0a1e5f6c4bd6df17834312ff577c1373d87b8;p=thirdparty%2Fkernel%2Flinux.git

PCI: mediatek: Fix unchecked return value

Check return value of devm_pci_remap_iospace().

Addresses-Coverity-ID: 1471965 ("Unchecked return value")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Honghui Zhang <honghui.zhang@mediatek.com>
---

diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c
index 861dda69f3669..1477939ef38a8 100644
--- a/drivers/pci/controller/pcie-mediatek.c
+++ b/drivers/pci/controller/pcie-mediatek.c
@@ -1109,7 +1109,9 @@ static int mtk_pcie_request_resources(struct mtk_pcie *pcie)
 	if (err < 0)
 		return err;
 
-	devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start);
+	err = devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start);
+	if (err)
+		return err;
 
 	return 0;
 }