From: Thierry Fournier <thierry.fournier@ozon.io>
Date: Thu, 8 Mar 2018 08:59:02 +0000 (+0100)
Subject: BUG/MINOR: lua funtion hlua_socket_settimeout don't check negative values
X-Git-Tag: v1.9-dev1~346
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=17a921b799631661803065f1873326b522e6bc3a;p=thirdparty%2Fhaproxy.git

BUG/MINOR: lua funtion hlua_socket_settimeout don't check negative values

Negatives timeouts doesn't have sense. A negative timeout doesn't cause
a crash, but the connection expires before the system try to extablish it.

This patch should be backported in all versions from 1.6
---

diff --git a/src/hlua.c b/src/hlua.c
index 3b87aa94f2..1541468f2b 100644
--- a/src/hlua.c
+++ b/src/hlua.c
@@ -2474,6 +2474,10 @@ __LJMP static int hlua_socket_settimeout(struct lua_State *L)
 	socket = MAY_LJMP(hlua_checksocket(L, 1));
 	tmout = MAY_LJMP(luaL_checkinteger(L, 2)) * 1000;
 
+	/* Check for negative values */
+	if (tmout < 0)
+		WILL_LJMP(luaL_error(L, "settimeout: cannot set negatives values"));
+
 	/* Check if we run on the same thread than the xreator thread.
 	 * We cannot access to the socket if the thread is different.
 	 */