From: Sean Christopherson Date: Thu, 10 Oct 2024 18:24:15 +0000 (-0700) Subject: KVM: PPC: Remove extra get_page() to fix page refcount leak X-Git-Tag: v6.13-rc1~97^2~17^2~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=17b7dbaf183e9cc131bbf5311db8202d323aa667;p=thirdparty%2Fkernel%2Flinux.git KVM: PPC: Remove extra get_page() to fix page refcount leak Don't manually do get_page() when patching dcbz, as gfn_to_page() gifts the caller a reference. I.e. doing get_page() will leak the page due to not putting all references. Signed-off-by: Sean Christopherson Tested-by: Dmitry Osipenko Signed-off-by: Paolo Bonzini Message-ID: <20241010182427.1434605-74-seanjc@google.com> --- diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c index d7721297b9b6e..cd7ab6d850909 100644 --- a/arch/powerpc/kvm/book3s_pr.c +++ b/arch/powerpc/kvm/book3s_pr.c @@ -652,7 +652,6 @@ static void kvmppc_patch_dcbz(struct kvm_vcpu *vcpu, struct kvmppc_pte *pte) hpage_offset &= ~0xFFFULL; hpage_offset /= 4; - get_page(hpage); page = kmap_atomic(hpage); /* patch dcbz into reserved instruction, so we trap */