From: Tero Kristo <t-kristo@ti.com>
Date: Tue, 25 Aug 2020 13:31:06 +0000 (+0300)
Subject: crypto: sa2ul - fix compiler warning produced by clang
X-Git-Tag: v5.10-rc1~181^2~144
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=17bce37e1b5eca95f9da783a07930b6d608c1389;p=thirdparty%2Fkernel%2Flinux.git

crypto: sa2ul - fix compiler warning produced by clang

Clang detects a warning for an assignment that doesn't really do
anything. Fix this by removing the offending piece of code.

Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com> # build
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index b685a76ae88cc..934e9a00638cf 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -1148,12 +1148,10 @@ static int sa_run(struct sa_req *req)
 			ret = sg_split(req->dst, mapped_dst_nents, 0, 1,
 				       &split_size, &dst, &dst_nents,
 				       gfp_flags);
-			if (ret) {
-				dst_nents = dst_nents;
+			if (ret)
 				dst = req->dst;
-			} else {
+			else
 				rxd->split_dst_sg = dst;
-			}
 		}
 	}