From: Arnd Bergmann Date: Wed, 7 Aug 2024 07:55:53 +0000 (+0200) Subject: leds: blinkm: Fix CONFIG_LEDS_CLASS_MULTICOLOR dependency X-Git-Tag: v6.12-rc1~87^2~24 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=17c40f3c94bc2279b879ea9ceb3eea973bcd1ac4;p=thirdparty%2Fkernel%2Flinux.git leds: blinkm: Fix CONFIG_LEDS_CLASS_MULTICOLOR dependency With CONFIG_LEDS_CLASS_MULTICOLOR=m, a builtin leds-blinkm driver causes a link failure: arm-linux-gnueabi-ld: drivers/leds/leds-blinkm.o: in function `blinkm_set_mc_brightness': leds-blinkm.c:(.text.blinkm_set_mc_brightness+0xc): undefined reference to `led_mc_calc_color_components' Add a more specific dependency that only allows multicoler mode to be enabled for blinkm if it can build and link. Fixes: 56e8c56c9af0 ("leds: Add multicolor support to BlinkM LED driver") Signed-off-by: Arnd Bergmann Acked-by: Joseph Strauss Link: https://lore.kernel.org/r/20240807075614.2118068-1-arnd@kernel.org Signed-off-by: Lee Jones --- diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 2e78318673151..b784bb74a8378 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -828,7 +828,7 @@ config LEDS_BLINKM config LEDS_BLINKM_MULTICOLOR bool "Enable multicolor support for BlinkM I2C RGB LED" depends on LEDS_BLINKM - depends on LEDS_CLASS_MULTICOLOR + depends on LEDS_CLASS_MULTICOLOR=y || LEDS_CLASS_MULTICOLOR=LEDS_BLINKM help This option enables multicolor sysfs class support for BlinkM LED and disables the older, separated sysfs interface