From: Sam James <sam@gentoo.org>
Date: Sat, 29 Jun 2024 10:07:18 +0000 (+0100)
Subject: ld: pass -g for ld-elf tests
X-Git-Tag: binutils-2_43~241
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=17c78a23491ce76fd6d21cdbf2db3c0cf02145e0;p=thirdparty%2Fbinutils-gdb.git

ld: pass -g for ld-elf tests

The "DWARF parse during linker error" and "Build warn libbar.so" tests
require debug information.

configure defaults to "-O2 -g" but if overriding *FLAGS when building
tests, this might be lost. Explicitly pass -g given these tests require
it.

Originally reported downstream in Gentoo at https://bugs.gentoo.org/934149.

ld/
	* testsuite/ld-elf/dwarf.exp: Pass -g for "DWARF parse during linker error".
	* testsuite/ld-elf/shared.exp: Ditto for "Build warn libbar.so".
---

diff --git a/ld/testsuite/ld-elf/dwarf.exp b/ld/testsuite/ld-elf/dwarf.exp
index a4748a47c98..1ca1ec54763 100644
--- a/ld/testsuite/ld-elf/dwarf.exp
+++ b/ld/testsuite/ld-elf/dwarf.exp
@@ -50,7 +50,7 @@ set build_tests {
    "-s -shared" "-fPIC -g -feliminate-dwarf2-dups"
    {dwarf1.c} {} "libdwarf1.so"}
   {"DWARF parse during linker error"
-   "" "-fno-toplevel-reorder"
+   "" "-g -fno-toplevel-reorder"
    {dwarf2a.c dwarf2b.c} {{error_output "dwarf2.err"}} "dwarf2.x"}
 }
 
diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp
index 9e89077af89..97ca778bc8e 100644
--- a/ld/testsuite/ld-elf/shared.exp
+++ b/ld/testsuite/ld-elf/shared.exp
@@ -552,7 +552,7 @@ set build_tests {
    "-shared" "-fPIC"
    {begin.c end.c} {} "libbar.so"}
   {"Build warn libbar.so"
-   "-shared" "-fPIC"
+   "-shared" "-fPIC -g"
   {beginwarn.c end.c}
   {{readelf {-S --wide} libbarw.rd}
    {warning {^.*beginwarn.c:7:\(.*\): warning: function foo is deprecated\n?$}}}