From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Fri, 30 Jun 2023 12:57:30 +0000 (+0200)
Subject: BUG/MINOR: quic: Wrong endianess for version field in Retry token
X-Git-Tag: v2.9-dev1~22
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=17eaee31c3a30153bee5785f2224d389c4159db2;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: Wrong endianess for version field in Retry token

This field must be sent in network byte order.

Must be backported as far as 2.6.
---

diff --git a/src/quic_conn.c b/src/quic_conn.c
index 6be031717d..074ac8cc32 100644
--- a/src/quic_conn.c
+++ b/src/quic_conn.c
@@ -6424,7 +6424,7 @@ static int quic_generate_retry_token_aad(unsigned char *aad,
 	unsigned char *p;
 
 	p = aad;
-	memcpy(p, &version, sizeof version);
+	*(uint32_t *)p = htonl(version);
 	p += sizeof version;
 	p += quic_saddr_cpy(p, addr);
 	memcpy(p, cid->data, cid->len);