From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 5 Dec 2016 13:23:37 +0000 (+0100)
Subject: MINOR: cli: Remove useless call to bi_putchk
X-Git-Tag: v1.8-dev1~291
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1821d3c25e80e1f687dc809901094b49aa670d98;p=thirdparty%2Fhaproxy.git

MINOR: cli: Remove useless call to bi_putchk

[wt: while it could seem suspicious, the preceeding call to
 dump_servers_state() indeed flushes the trash in case anything is
emitted. No backport needed though.]
---

diff --git a/src/proxy.c b/src/proxy.c
index 90e9b23d94..81daaa6e4c 100644
--- a/src/proxy.c
+++ b/src/proxy.c
@@ -1360,11 +1360,6 @@ static int cli_io_handler_servers_state(struct appctx *appctx)
 		if (curproxy->cap & PR_CAP_BE) {
 			if (!dump_servers_state(si, &trash))
 				return 0;
-
-			if (bi_putchk(si_ic(si), &trash) == -1) {
-				si_applet_cant_put(si);
-				return 0;
-			}
 		}
 		/* only the selected proxy is dumped */
 		if (appctx->ctx.server_state.iid)