From: Willy Tarreau <w@1wt.eu>
Date: Wed, 12 Apr 2017 16:54:00 +0000 (+0200)
Subject: BUG/MINOR: config: missing goto out after parsing an incorrect ACL character
X-Git-Tag: v1.8-dev2~90
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1822e8c35614fb01f25661ea541d9e0599b56a59;p=thirdparty%2Fhaproxy.git

BUG/MINOR: config: missing goto out after parsing an incorrect ACL character

The error doesn't prevent checking for other errors after an invalid
character was detected in an ACL name. Better quit ASAP to avoid risking
to emit garbled and confusing error messages if something else fails on
the same line.

This should be backported to 1.7, 1.6 and 1.5.
---

diff --git a/src/cfgparse.c b/src/cfgparse.c
index e1b6b3ebab..47d33cf1b0 100644
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -3154,6 +3154,7 @@ int cfg_parse_listen(const char *file, int linenum, char **args, int kwm)
 			Alert("parsing [%s:%d] : character '%c' is not permitted in acl name '%s'.\n",
 			      file, linenum, *err, args[1]);
 			err_code |= ERR_ALERT | ERR_FATAL;
+			goto out;
 		}
 
 		if (parse_acl((const char **)args + 1, &curproxy->acl, &errmsg, &curproxy->conf.args, file, linenum) == NULL) {