From: Pauli <pauli@openssl.org>
Date: Thu, 4 Nov 2021 02:46:58 +0000 (+1000)
Subject: Address Coverity 1493387 Logically dead code
X-Git-Tag: openssl-3.2.0-alpha1~3384
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=182cc644b3a3690bddfecba925486fefa421d6ec;p=thirdparty%2Fopenssl.git

Address Coverity 1493387 Logically dead code

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/16962)
---

diff --git a/crypto/evp/m_sigver.c b/crypto/evp/m_sigver.c
index 2972734d8d9..80570973dd1 100644
--- a/crypto/evp/m_sigver.c
+++ b/crypto/evp/m_sigver.c
@@ -462,14 +462,14 @@ int EVP_DigestSignFinal(EVP_MD_CTX *ctx, unsigned char *sigret,
     if (sigret == NULL || (ctx->flags & EVP_MD_CTX_FLAG_FINALISE) != 0)
         return pctx->op.sig.signature->digest_sign_final(pctx->op.sig.algctx,
                                                          sigret, siglen,
-                                                         (sigret == NULL) ? 0 : *siglen);
+                                                         (siglen == NULL) ? 0 : *siglen);
     dctx = EVP_PKEY_CTX_dup(pctx);
     if (dctx == NULL)
         return 0;
 
     r = dctx->op.sig.signature->digest_sign_final(dctx->op.sig.algctx,
                                                   sigret, siglen,
-                                                  (sigret == NULL) ? 0 : *siglen);
+                                                  (siglen == NULL) ? 0 : *siglen);
     EVP_PKEY_CTX_free(dctx);
     return r;