From: Ben Darnell Date: Sun, 23 Apr 2023 19:15:05 +0000 (-0400) Subject: test: Close a websocket client that causes occasional test failures X-Git-Tag: v6.3.2~2^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1849ef6c48415ef8f5fecbd47d9f68225588507c;p=thirdparty%2Ftornado.git test: Close a websocket client that causes occasional test failures These failures occur on the build.yml workflow on the emulated arm64 platform: an ill-timed timer firing during test shutdown can result in a message being logged and the test failing for dirty logs. --- diff --git a/tornado/test/websocket_test.py b/tornado/test/websocket_test.py index f90c5f2c0..0a29ae646 100644 --- a/tornado/test/websocket_test.py +++ b/tornado/test/websocket_test.py @@ -807,6 +807,7 @@ class ClientPeriodicPingTest(WebSocketBaseTestCase): response = yield ws.read_message() self.assertEqual(response, "got ping") # TODO: test that the connection gets closed if ping responses stop. + ws.close() class ManualPingTest(WebSocketBaseTestCase):