From: Aaron Merey <amerey@redhat.com>
Date: Sat, 12 Feb 2022 00:28:47 +0000 (-0500)
Subject: gdb-add-index: disable debuginfod
X-Git-Tag: gdb-12.1-release~223
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=18694ad5bddc06bea69600d97f048f255e02494f;p=thirdparty%2Fbinutils-gdb.git

gdb-add-index: disable debuginfod

gdb-add-index may trigger debuginfod's first-use notice.  The notice
is misleading in this case.  It instructs the user to modify .gdbinit
in order to permanently enable/disable debuginfod but gdb-add-index
invokes gdb with -nx which ignores .gdbinit.

Additionally debuginfod is not needed for gdb-add-index since the
symbol file is given as an argument and should already be present
locally.

Fix this by disabling debuginfod when gdb-add-index invokes gdb.
---

diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh
index 0ff943d506e..591f32bbbbe 100755
--- a/gdb/contrib/gdb-add-index.sh
+++ b/gdb/contrib/gdb-add-index.sh
@@ -112,6 +112,7 @@ rm -f $tmp_files
 trap "rm -f $tmp_files" 0
 
 $GDB --batch -nx -iex 'set auto-load no' \
+    -iex 'set debuginfod enabled off' \
     -ex "file $file" -ex "save gdb-index $dwarf5 $dir" || {
     # Just in case.
     status=$?