From: Flavio Cruz <flaviocruz@gmail.com>
Date: Sun, 22 Dec 2024 05:34:35 +0000 (-0500)
Subject: gdb/hurd: remove VLA usage
X-Git-Tag: gdb-16-branchpoint~26
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1898ec362a5930c6925d84785b681576acdbcb99;p=thirdparty%2Fbinutils-gdb.git

gdb/hurd: remove VLA usage

Compilation will fail with -Werror=vla, which seems to be the default.

Note that we don't need to allocate num_threads + 1 since the matching
algorithm works only on the num_threads as returned by task_threads.

Change-Id: I276928d0ff3c52c7c7fe4edb857e5789cdabfcf7
---

diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
index a8a4da1c873..c6fe7a9ab5c 100644
--- a/gdb/gnu-nat.c
+++ b/gdb/gnu-nat.c
@@ -1016,15 +1016,16 @@ gnu_nat_target::inf_validate_procs (struct inf *inf)
   {
     /* Make things normally linear.  */
     mach_msg_type_number_t search_start = 0;
-    /* Which thread in PROCS corresponds to each task thread, & the task.  */
-    struct proc *matched[num_threads + 1];
+
+    /* Which thread in PROCS corresponds to each task thread.  */
+    std::vector<struct proc *> matched (num_threads);
+
     /* The last thread in INF->threads, so we can add to the end.  */
     struct proc *last = 0;
+
     /* The current thread we're considering.  */
     struct proc *thread = inf->threads;
 
-    memset (matched, 0, sizeof (matched));
-
     while (thread)
       {
 	mach_msg_type_number_t left;