From: Christos Tsantilas <chtsanti@users.sourceforge.net>
Date: Thu, 23 Jun 2011 09:51:08 +0000 (+0300)
Subject: Bug 3239: Rename myip/myport as localip/localport - Fix initial patch
X-Git-Tag: take08~55^2~100
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=18c41901ad49f3a96bd4bbe0269705460e40d5bb;p=thirdparty%2Fsquid.git

Bug 3239: Rename myip/myport as localip/localport - Fix initial patch

A misstyped  if(strcmp ...) statemets has as result, all acl type in squid.conf
to be considered as "localip" acl type.
---

diff --git a/src/acl/Acl.cc b/src/acl/Acl.cc
index 4ac0d7514d..39ba89ba1e 100644
--- a/src/acl/Acl.cc
+++ b/src/acl/Acl.cc
@@ -122,7 +122,7 @@ ACL::ParseAclLine(ConfigParser &parser, ACL ** head)
     }
 
     // Is this ACL going to work?
-    if (strcmp(theType, "myip") != 0) {
+    if (strcmp(theType, "myip") == 0) {
         http_port_list *p = Config.Sockaddr.http;
         while (p) {
             // Bug 3239: not reliable when there is interception traffic coming
@@ -132,7 +132,7 @@ ACL::ParseAclLine(ConfigParser &parser, ACL ** head)
         }
         debugs(28, DBG_IMPORTANT, "UPGRADE: ACL 'myip' type is has been renamed to 'localip' and matches the IP the client connected to.");
         theType = "localip";
-    } else if (strcmp(theType, "myport") != 0) {
+    } else if (strcmp(theType, "myport") == 0) {
         http_port_list *p = Config.Sockaddr.http;
         while (p) {
             // Bug 3239: not reliable when there is interception traffic coming