From: Randy Dunlap Date: Tue, 31 Jul 2018 11:06:58 +0000 (+0200) Subject: fb: amifb: fix build warnings when not builtin X-Git-Tag: v4.19-rc1~37^2~8 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=195197f408567b54b312c54518fbca653c5442c6;p=thirdparty%2Fkernel%2Flinux.git fb: amifb: fix build warnings when not builtin Fix build warning when built as a loadable module. amifb_setup() and amifb_setup_mcap() are only needed when the driver is builtin. This matches how the functions are called (using #ifndef MODULE). ../drivers/video/fbdev/amifb.c:2344:19: warning: 'amifb_setup' defined but not used [-Wunused-function] static int __init amifb_setup(char *options) ../drivers/video/fbdev/amifb.c:2307:20: warning: 'amifb_setup_mcap' defined but not used [-Wunused-function] static void __init amifb_setup_mcap(char *spec) Signed-off-by: Randy Dunlap Reviewed-by: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c index cc11c60612980..0777aff211e5c 100644 --- a/drivers/video/fbdev/amifb.c +++ b/drivers/video/fbdev/amifb.c @@ -2303,7 +2303,7 @@ static void ami_build_copper(struct fb_info *info) ami_rebuild_copper(info->par); } - +#ifndef MODULE static void __init amifb_setup_mcap(char *spec) { char *p; @@ -2368,7 +2368,7 @@ static int __init amifb_setup(char *options) return 0; } - +#endif static int amifb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)